feat(liboqs): allow setting OQS_PERMIT_UNSUPPORTED_ARCHITECTURE CMake option via environment variable
#203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to set the `OQS_PERMIT_UNSUPOPORTED_ARCHITECTURE` CMake option via an environment variable.
|
I'm not sure if an environment variable is the best way of doing this... But I also don't want to turn it into a feature, because it's not exactly a supported configuration: with unsupported architectures there's a good chance of generating non-constant-time code. |
thomwiggers
approved these changes
May 1, 2023
|
Could you rebase this please? |
auto-merge was automatically disabled
September 20, 2023 15:45
Merge queue setting changed
|
@wucke13 Could you rebase this? |
thomwiggers
changed the title
OQS_PERMIT_UNSUPPORTED_ARCHITECTURE CMake option via environment variable
bacnh85
pushed a commit
to bacnh85/liboqs-rust
that referenced
this pull request
Feb 15, 2024
…ke option via environment variable (open-quantum-safe#203) fix open-quantum-safe#202 This allows to set the `OQS_PERMIT_UNSUPOPORTED_ARCHITECTURE` CMake option via an environment variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to set the
OQS_PERMIT_UNSUPOPORTED_ARCHITECTURECMake option via an environment variable.